-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: WASI Observe prototype #2485
base: main
Are you sure you want to change the base?
Conversation
4b578a5
to
5d5ff30
Compare
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
f4f25a1
to
a4ece30
Compare
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one review comment has been pending for a month. 😐
|
||
pub trait FutureExt: Future + Sized { | ||
/// Manage WASI Observe guest spans. | ||
fn manage_guest_spans( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe manage_wasi_observe_spans
? At the call site it won't be obvious where this method comes from.
This is a host component that backs the WASI Observe WIT. The API is very much in flux right now so it is just a draft.